[security] Build script points to an unclaimed s3 bucket. #26
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hash would prevent executing untrusted code, but we want to make sure future maintainers don't get tricked into updating the hash to match an invalid package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hash would prevent executing untrusted code, but we want to make sure future maintainers don't get tricked into updating the hash to match an invalid package.
It would be nice to get the build script up and running again with a newer version of emscripten, but we just want to quickly take care of this loose end before we have a chance to forget about it.
cc @mourner @IamGreut @asheemmamoowala