This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Auto-coerce top-level results and concat arguments to strings #12892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisLoer
reviewed
Sep 14, 2018
| @@ -52,6 +52,12 @@ class Scope { | |||
|
|
|||
| } // namespace detail | |||
|
|
|||
| enum class TypeAnnotationOption { | |||
There was a problem hiding this comment.
Can we include a comment here describing how these are used? The part that I think is confusing is that there's kind of a fourth option (nullopt) which I think means something like "coerce or assert depending on expected type".
jfirebaugh
force-pushed
the
concat-to-string
branch
from
fbe6159
to
e47f012
Compare
ChrisLoer
force-pushed
the
concat-to-string
branch
from
276b37a
to
52bc084
Compare
ChrisLoer
approved these changes
Sep 18, 2018
ChrisLoer
added
needs changelog
ChrisLoer
force-pushed
the
concat-to-string
branch
from
fac3512
to
3031d91
Compare
ChrisLoer
force-pushed
the
concat-to-string
branch
from
0d4b197
to
7b18f44
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native counterpart to mapbox/mapbox-gl-js#7280.