This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Add getLayer and getSource snapshotter methods #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshalamov
force-pushed
the
alexshalamov_add_snapshotter_methods
branch
from
f1d286d
to
3376cc1
Compare
2 tasks
|
Added example activity. Top view is a map view, the view below is an image view with an image from snapshotter with modified style.
|
tobrun
approved these changes
Mar 25, 2020
MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/snapshotter/MapSnapshotter.java
Outdated
Show resolved
Hide resolved
MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/snapshotter/MapSnapshotter.java
Outdated
Show resolved
Hide resolved
MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/snapshotter/MapSnapshotter.java
Outdated
Show resolved
Hide resolved
alexshalamov
force-pushed
the
alexshalamov_add_snapshotter_methods
branch
2 times, most recently
from
9938c04
to
cffb842
Compare
alexshalamov
force-pushed
the
alexshalamov_add_snapshotter_methods
branch
from
cffb842
to
3621dbc
Compare
Chaoba
pushed a commit
that referenced
this pull request
Mar 26, 2020
* Expose snapshotter layer and source objects * Add example snapshotter + within activity * Bump vendor/mapbox-gl-native (cherry picked from commit 6984dbf)
Chaoba
pushed a commit
that referenced
this pull request
Mar 27, 2020
* Expose snapshotter layer and source objects * Add example snapshotter + within activity * Bump vendor/mapbox-gl-native (cherry picked from commit 6984dbf)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add getLayer, getSource and Observer interface for a MapSnapshotter, so that the developer can modify snapshotter's layer and/or source object's properties.
<changelog>A snapshotter's layers and sources can now be modified by using theonDidFinishLoadingStyle()callback and APIs to retrieve layer/source properties from a style.</changelog>note from @chloekraw: I'm not sure if a separate changelog entry for this PR is needed since it's a necessary part of enabling runtime styling in the snapshotter, and the latter will be discussed in the changelog. Let's see when we draft the changelog.