This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Add runtime styling APIs on MapSnapshotter #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tobrun Can you review MapSnapshotStyle API? |
chloekraw
changed the title
tobrun
reviewed
Mar 12, 2020
There was a problem hiding this comment.
While we aren't able to use the Style.java object itself (it's tightly coupled to a Map). I think we can reuse the Style#Builder to compose our style. This could be exposed through MapSnapshotter#Options. We will need to expose getters on the builder to get the values we need as we won't be creating an actual instance of the Style.java with build().
Chaoba
force-pushed
the
kl-snapshotter
branch
2 times, most recently
from
4fc9a75
to
dddb17e
Compare
|
@tobrun This pr is ready for review now. There are some tail works need to do:
|
MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/style/layers/CustomLayer.java
Show resolved
Hide resolved
MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/snapshotter/MapSnapshotter.java
Outdated
Show resolved
Hide resolved
Chaoba
changed the title
Chaoba
force-pushed
the
kl-snapshotter
branch
3 times, most recently
from
11e3747
to
cb5adb6
Compare
Closed
|
Was able to hit a native crash while opening/closing some of the examples. The native crash is symbolicated with |
|
I am able to reproduce the crash too. It seem still happens during the deconstruction process. |
|
Find another crash by opening "Map Snapshotter with Marker" and back for several times. From the stacktrace, it is related with |
|
And for the previous crash, it can only reproduced with emulator. I have tried with my XiaoMi8, not able to reproduce it. |
|
Tested this out and is looking 👍 |
tobrun
reviewed
Mar 20, 2020
| nativeSetStyleUrl(styleUrl); | ||
| } | ||
|
|
||
| // TODO: Documentation |
MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/snapshotter/MapSnapshotter.java
Show resolved
Hide resolved
MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/snapshotter/MapSnapshotter.java
Outdated
Show resolved
Hide resolved
We already have symbol layer example in https://github.com/mapbox/mapbox-gl-native-android/pull/268/files#diff-4707ad1bd4eb1163d43de02e0757f695R146, heatmap example added. |
|
@Chaoba @tobrun @alexshalamov have we been able to repro and fix mapbox/mapbox-gl-native#11669? |
Chaoba
pushed a commit
that referenced
this pull request
Mar 26, 2020
* Add styleable snapshotter. * Add style API for snapshotter * Add observer interface to snapshotter * WIP Add styling to snapshotter activity * Update interface and implement addlayer functions. * Deprecate methods instead of removing * Implement addSource functions. * Implement addImage function * Still use the previous callback interface. * Expose onStyleDidloaded interface * Add setStyle method * Start native snapshotter from start method * Fix snapshotter test. * Fix check style * Keep the original interface * Update gl-native * Add demo for snapshotter heatmap layer * bump gl-native Co-authored-by: Alexander Shalamov <alexander.shalamov@mapbox.com> (cherry picked from commit da6d8a2)
Chaoba
pushed a commit
that referenced
this pull request
Mar 27, 2020
* Add styleable snapshotter. * Add style API for snapshotter * Add observer interface to snapshotter * WIP Add styling to snapshotter activity * Update interface and implement addlayer functions. * Deprecate methods instead of removing * Implement addSource functions. * Implement addImage function * Still use the previous callback interface. * Expose onStyleDidloaded interface * Add setStyle method * Start native snapshotter from start method * Fix snapshotter test. * Fix check style * Keep the original interface * Update gl-native * Add demo for snapshotter heatmap layer * bump gl-native Co-authored-by: Alexander Shalamov <alexander.shalamov@mapbox.com> (cherry picked from commit da6d8a2)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resovles #220
This pr add new api that could add runtime layer for snapshotter.
The jni binding pr: mapbox/mapbox-gl-native#16286