Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-coerce top-level results and concat arguments to strings #7280

Merged
merged 8 commits into from Sep 18, 2018

Commits on Sep 13, 2018

  1. Configuration menu
    Copy the full SHA
    f42af5b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4256281 View commit details
    Browse the repository at this point in the history
  3. Simplify how token strings are converted

    No longer need to-string when using concat. However, it is still needed if the token string consists of a single token.
    jfirebaugh committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    1ff116c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3b480cd View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2018

  1. Configuration menu
    Copy the full SHA
    85fce01 View commit details
    Browse the repository at this point in the history
  2. Split Collator/Formatted types into separate files

    This avoids a troublesome circular import.
    jfirebaugh committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    11b6a19 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2018

  1. Complete transition to coercing 'text-field' to 'formatted' at evalua…

    …tion time.
    
     - Add coercion after call to 'getValueAndResolveTokens`, since the non-expression pathway here skips the coercion logic in parsing_context
     - Remove 'string | Formatted' typing and 'text instanceof Formatted' checks
     - Add Coercion support for 'Formatted', along with dedicated serialization
     - Use Coercion when parsing expected.kind === 'formatted' instead of directly creating a FormatExpression. This is necessary to accommodate expressions such as 'coalesce' that introduce a typeAnnotation.
    ChrisLoer committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    b0dffd2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2474692 View commit details
    Browse the repository at this point in the history