don't clear state on reload, just on setData #7129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asheemmamoowala
approved these changes
Aug 14, 2018
| @@ -75,6 +75,7 @@ class SourceCache extends Evented { | |||
| // for sources with mutable data, this event fires when the underlying data | |||
| // to a source is changed. (i.e. GeoJSONSource#setData and ImageSource#serCoordinates) | |||
| if (this._sourceLoaded && !this._paused && e.dataType === "source" && e.sourceDataType === 'content') { | |||
| if (this._source.type === "geojson") this.resetState(); | |||
mollymerp
added a commit
that referenced
this pull request
Aug 14, 2018
mollymerp
added a commit
that referenced
this pull request
Aug 16, 2018
jfirebaugh
added a commit
that referenced
this pull request
Aug 16, 2018
jfirebaugh
added a commit
that referenced
this pull request
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #7043 we added a fresh state on source
reloadbut reload is also called when a style property or layout property is changed that requires relayout, so we were inadvertently expunging the state whenever that happened. originally reported in #6289 (comment)Launch Checklist