Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple text formats for symbols via "format" expression #6994

Merged
merged 5 commits into from Aug 8, 2018
Merged

Multiple text formats for symbols via "format" expression #6994

merged 5 commits into from Aug 8, 2018

Commits on Aug 1, 2018

  1. Introduce "format" expression. 

    Returns "formatted" type with formatting annotations applied to subsections.
"text-field" now accepts formatted text, allowing symbols to use multiple fonts within the same label.
    @ChrisLoer
    ChrisLoer committed Aug 1, 2018
    Copy the full SHA
    f11e6c7 View commit details
    Browse the repository at this point in the history

  2. Support implicit argument coercions for compound expressions with mul… 

    …tiple overloads.

Support string->formatted coercion (currently unused).
    @ChrisLoer
    ChrisLoer committed Aug 1, 2018
    Copy the full SHA
    c88b4dd View commit details
    Browse the repository at this point in the history

  3. Update to mapbox-gl-rtl-text 0.2.0 for formatted text support. 

    Add test using new formatted RTL functionality.
    @ChrisLoer
    ChrisLoer committed Aug 1, 2018
    Copy the full SHA
    c742e35 View commit details
    Browse the repository at this point in the history

  4. Address review comments: 

    - "FormattedExpression" -> "FormatExpression" (reasoning: the expression itself is a verb, the result is a noun)
- Remove dead/debug code
- Add comments
    @ChrisLoer
    ChrisLoer committed Aug 1, 2018
    Copy the full SHA
    e9bbaac View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2018

  1. Require that text-font format argument be an array of strings.

    @ChrisLoer
    ChrisLoer committed Aug 3, 2018
    Copy the full SHA
    d2e6dcc View commit details
    Browse the repository at this point in the history