Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (accessibility): Remove redundant aria-label that fails accessibility conformance #12981

Merged

Conversation

maggiewachs
Copy link
Contributor

Fixes #12955

Summary

  • The "Improve this map" link fails accessibility standards defined in WCAG SC 2.5.3: Label in Name (Level A) because the visible link text is not included in the aria-label attribute.
  • This error is present in every default installation of Mapbox that includes the attribution block:
    image
  • Removing the aria-label (a single line in the source) means we don't need to create a hacky workaround to eliminate the accessible name mismatch, and would benefit all users of Mapbox, especially those who rely on assistive tech (voice control, screen readers, etc)
  • This fix may also improve Mapbox's feedback analytics :)

Verified locally

  • the aria-label is no longer present on the "Improve this map" link
  • screen reader announces the visible text correctly when the link is focused (VoiceOver with Safari, MacOS 14.1)
  • Chrome DevTools correctly identifies the link's accessible name as "Improve this map", and matches the visible link text

Launch Checklist

  • Make sure the PR title is descriptive and preferably reflects the change from the user's perspective.
  • Add additional detail and context in the PR description (with screenshots/videos if there are visual changes).
  • Manually test the debug page.
  • Write tests for all new functionality and make sure the CI checks pass.
  • Document any changes to public APIs.
  • Post benchmark scores if the change could affect performance.
  • Tag @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes.
  • Tag @mapbox/gl-native if this PR includes shader changes or needs a native port.

@maggiewachs maggiewachs requested a review from a team as a code owner November 21, 2023 14:58
@CLAassistant
Copy link

CLAassistant commented Nov 21, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @maggiewachs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility] The map feedback link has a wrong aria-label attribute
3 participants