Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updating image before initial image is loaded or the loading failed #12928

Closed

Conversation

maciejmatu
Copy link
Contributor

This PR fixes issue with updating image source immediately after creating the source, or after a failed image request, mentioned in #11725. The only change is removal of condition that disallowed updating image until this.image was instantiated on the ImageSource class.

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Allow ImageSource.updateImage to be called before initial image loads or fails to load</changelog>

@stepankuzmin
Copy link
Contributor

Hi @maciejmatu,

Thanks for the contribution! I see one render test is failing continuously. Could you please rebase your PR on top of the main branch?

@maciejmatu
Copy link
Contributor Author

Thanks @stepankuzmin I've had some troubles, and it kept failing. Should I close this PR?

@stepankuzmin
Copy link
Contributor

Yep, I'll close this PR after we merge the rebased one. Thanks again for the contribution 🙏

@stepankuzmin
Copy link
Contributor

Merged in #12992

@maciejmatu
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants