Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding full screen toggle example #1311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding full screen toggle example #1311

wants to merge 1 commit into from

Conversation

langsmith
Copy link
Contributor

This pr shows how to toggle between a regular map and full screen map. Similar to what we have in Studio Preview app

ezgif com-resize

@langsmith langsmith requested a review from tobrun March 11, 2020 19:53
@langsmith langsmith self-assigned this Mar 11, 2020
tobrun
tobrun approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the map resizes? It would feel more material if the map stays the same size and the toolbar overlays it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobrun tobrun tobrun approved these changes

Assignees

@langsmith langsmith

Labels
new example ✨ ✓ ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@langsmith @tobrun