Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeocodeOptions.locale loses script and country codes #109

Open
1ec5 opened this issue Jun 1, 2017 · 1 comment
Open

GeocodeOptions.locale loses script and country codes #109

1ec5 opened this issue Jun 1, 2017 · 1 comment
Labels

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jun 1, 2017

GeocodeOptions only passes along the bare language code to the Geocoding API. For example, even if the system locale is Traditional Chinese (Hong Kong) and the developer sets the locale property to Locale.current, the language query parameter ends up being zh instead of zh-Hant-HK. GeocodeOptions should pass along the entire locale identifier; it would be API’s responsibility to strip any components it doesn’t need or understand.

/cc @apendleton

@apendleton
Copy link

Sounds good. Subtags will definitely improve results in Chinese in particular, and probably also in a couple of other languages where more than one script is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants