Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server-side localized instructions #133

Closed
1ec5 opened this issue Jun 1, 2017 · 1 comment
Closed

Server-side localized instructions #133

1ec5 opened this issue Jun 1, 2017 · 1 comment
Labels
improvement Improvement for an existing feature.

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jun 1, 2017 •
edited

The Directions API has a new language query parameter (documentation forthcoming) that localizes the instruction property using OSRM Text Instructions. Developers who aren’t using real-time, turn-by-turn guidance instructions would be able to use this instruction property directly without having to link against OSRM Text Instructions for Swift.

The language query parameter doesn’t currently fall back to a similar language when an unsupported language code is provided. For now, we should omit the parameter by default but consider defaulting it to Locale.current in the future.

mapbox/mapbox-java#474 is the equivalent issue for Java.

/cc @freenerd @frederoni
@1ec5 1ec5 added the improvement Improvement for an existing feature. label Jun 1, 2017
@1ec5 1ec5 mentioned this issue Jun 1, 2017
Closed
@1ec5
Copy link
Contributor Author

1ec5 commented Jun 1, 2017 •
edited

Here’s the corresponding locale option in MapboxGeocoder.swift (but note mapbox/MapboxGeocoder.swift#109).

@1ec5 1ec5 mentioned this issue Jul 15, 2017
Closed
@1ec5 1ec5 mentioned this issue Aug 22, 2017
Closed
@1ec5 1ec5 mentioned this issue Sep 15, 2017
Merged
@bsudekum bsudekum mentioned this issue Sep 15, 2017
Merged
@1ec5 1ec5 mentioned this issue Nov 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvement for an existing feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@1ec5