Gnome 44 and search fix #186

VortexAcherontic · 2023-03-27T20:23:43Z

Add Gnome 44 to supported shell versions.
Tested this on my local machine and found the extension to still function properly with Gnome 44. (With ❤️ from the Emoji Selector)

Add Gnome 44 to supported shell versions. Tested this on my local machine and found the extension to still function properly with Gnome 44. (With ❤️ from the Emoji Selector)

tim-hm · 2023-03-28T10:56:55Z

This is also working for me on gnome 44 (lunar lobster)

tim-hm · 2023-04-06T08:36:15Z

This no long appears to work on 44.rc. Logs and screen cast below.

Screencast.from.2023-04-06.09-33-29.webm

JS ERROR: Exception in callback for signal: open-state-changed: TypeError: results.includes is not a function
searchEmoji@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiCategory.js:131:16
_getResults@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:116:36
_onSearchTextChanged@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:85:18
_onSearchTextChanged@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:254:19
clearCategories@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:249:8
_onOpenStateChanged@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:151:8
_callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
_emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
close@resource:///org/gnome/shell/ui/popupMenu.js:944:14
_onMenuOpenState@resource:///org/gnome/shell/ui/popupMenu.js:1351:27
_callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
_emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
open@resource:///org/gnome/shell/ui/popupMenu.js:927:14
_changeMenu@resource:///org/gnome/shell/ui/popupMenu.js:1362:17
_onCapturedEvent@resource:///org/gnome/shell/ui/popupMenu.js:1386:22

VortexAcherontic · 2023-04-12T19:59:53Z

This no long appears to work on 44.rc. Logs and screen cast below.

JS ERROR: Exception in callback for signal: open-state-changed: TypeError: results.includes is not a function
searchEmoji@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiCategory.js:131:16
_getResults@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:116:36
_onSearchTextChanged@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:85:18
_onSearchTextChanged@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:254:19
clearCategories@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:249:8
_onOpenStateChanged@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:151:8
_callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
_emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
close@resource:///org/gnome/shell/ui/popupMenu.js:944:14
_onMenuOpenState@resource:///org/gnome/shell/ui/popupMenu.js:1351:27
_callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
_emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
open@resource:///org/gnome/shell/ui/popupMenu.js:927:14
_changeMenu@resource:///org/gnome/shell/ui/popupMenu.js:1362:17
_onCapturedEvent@resource:///org/gnome/shell/ui/popupMenu.js:1386:22

Found and fixed the issue.
Changes are pending in this PR

rapenne-s · 2023-04-12T20:56:02Z

works for me, great job 👌

khaled-0 · 2023-04-19T15:29:13Z

bump
@maoschanz please migrate to gnome44

emoji-selector@maestroschan.fr/emojiSearchItem.js

RedAuburn · 2023-05-05T20:53:00Z

Works perfectly on Fedora 38, thanks!!
@maoschanz please merge soon :)

Kalitsune · 2023-05-26T14:03:44Z

works for me as well, thx!

khaled-0 · 2023-05-31T13:46:41Z

This is getting very late now.
I wonder if anything happened to the author.🙄
Hopefully he's alright

RedAuburn · 2023-06-14T13:57:47Z

sent an email, hopefully we can get an update :)

timreach · 2023-06-27T14:05:49Z

...he has made commits on other projects. Dude, please add some other people to help caretake this project if you are busy with other things 🙏 this extension is too good 😆

rapenne-s · 2023-07-03T14:57:32Z

this must be the most approved PR on GitHub 🥳

VortexAcherontic · 2023-07-03T16:05:18Z

this must be the most approved PR on GitHub 🥳

Unfortunately GitHub has no badges for this 😂

VortexAcherontic · 2023-07-19T15:38:54Z

Hey @maoschanz this is a kind request to merge this PR. Or did I missed something which makes this merge an issue?

1e4 · 2023-07-26T19:21:51Z

Hey @maoschanz this is a kind request to merge this PR. Or did I missed something which makes this merge an issue?

Might be worth forking if you plan on maintaining it in the future, I don't think there are any plans for supporting this unless they only plan on supporting LTS

FelipeFTN · 2023-07-26T23:14:21Z

Hey @maoschanz this is a kind request to merge this PR. Or did I missed something which makes this merge an issue?

Might be worth forking if you plan on maintaining it in the future, I don't think there are any plans for supporting this unless they only plan on supporting LTS

I highly agree, but I don't know if would be possible to publish the same application into Gnome Extensions.
But I'm available to fork and publish if possible.

timreach · 2023-09-01T13:19:15Z

Hey @maoschanz this is a kind request to merge this PR. Or did I missed something which makes this merge an issue?

Might be worth forking if you plan on maintaining it in the future, I don't think there are any plans for supporting this unless they only plan on supporting LTS

I highly agree, but I don't know if would be possible to publish the same application into Gnome Extensions. But I'm available to fork and publish if possible.

For it in a new extension dude, this is pretty much an abandoned project as it stands

* Gnome 44 Add Gnome 44 to supported shell versions. Tested this on my local machine and found the extension to still function properly with Gnome 44. (With ❤️ from the Emoji Selector) maoschanz/emoji-selector-for-gnome#186 * Fix search not working * Remove debug comment --------- Co-authored-by: Vortex Acherontic <vortex@z-ray.de>

FelipeFTN

Hi Folks!
The new repo was created!🚀
I changed the name to Emoji Copy, so I could publish on Gnome Extensions!
I will keep it updated and you guys can open Issues & Pull Requests there! 😃

Feel free do use and contribute there! Maybe we could change the interface or add completely new features and make it not just a fork but a brand new Emoji project. ❤️

Gnome 44

ece11ca

Add Gnome 44 to supported shell versions. Tested this on my local machine and found the extension to still function properly with Gnome 44. (With ❤️ from the Emoji Selector)

rapenne-s mentioned this pull request Apr 6, 2023

Search not working #185

Open

Fix search not working

e463fb3

Remove debug comment

ac3dca3

VortexAcherontic changed the title ~~Gnome 44~~ Gnome 44 and search fix Apr 12, 2023

rapenne-s approved these changes Apr 12, 2023

View reviewed changes

khaled-0 reviewed Apr 27, 2023

View reviewed changes

emoji-selector@maestroschan.fr/emojiSearchItem.js Show resolved Hide resolved

gnuns approved these changes May 17, 2023

View reviewed changes

Henry78 mentioned this pull request May 19, 2023

Version at extensions.gnome.org really outdated #188

Open

Depado approved these changes May 24, 2023

View reviewed changes

VortexAcherontic requested review from sidevesh and khaled-0 June 4, 2023 10:55

khaled-0 approved these changes Jun 9, 2023

View reviewed changes

sidevesh approved these changes Jun 14, 2023

View reviewed changes

FelipeFTN approved these changes Jun 29, 2023

View reviewed changes

koponomarenko approved these changes Jul 3, 2023

View reviewed changes

bmonjoie approved these changes Jul 3, 2023

View reviewed changes

ItzYanick approved these changes Jul 3, 2023

View reviewed changes

RedAuburn approved these changes Jul 3, 2023

View reviewed changes

RoiArthurB approved these changes Jul 3, 2023

View reviewed changes

brunobertoldi approved these changes Aug 31, 2023

View reviewed changes

Merge branch 'maoschanz:master' into master

e523aa8

FelipeFTN mentioned this pull request Sep 1, 2023

Gnome 44 and search fix FelipeFTN/Emoji-Copy#1

Merged

FelipeFTN approved these changes Sep 1, 2023

View reviewed changes

q-wertz mentioned this pull request Nov 6, 2023

Gnome 45 support #193

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gnome 44 and search fix #186

Gnome 44 and search fix #186

VortexAcherontic commented Mar 27, 2023

tim-hm commented Mar 28, 2023

tim-hm commented Apr 6, 2023 •

edited

VortexAcherontic commented Apr 12, 2023

rapenne-s commented Apr 12, 2023

khaled-0 commented Apr 19, 2023

RedAuburn commented May 5, 2023 •

edited

Kalitsune commented May 26, 2023

khaled-0 commented May 31, 2023

RedAuburn commented Jun 14, 2023

timreach commented Jun 27, 2023

rapenne-s commented Jul 3, 2023

VortexAcherontic commented Jul 3, 2023

VortexAcherontic commented Jul 19, 2023

1e4 commented Jul 26, 2023

FelipeFTN commented Jul 26, 2023

timreach commented Sep 1, 2023

FelipeFTN left a comment

Gnome 44 and search fix #186

Are you sure you want to change the base?

Gnome 44 and search fix #186

Conversation

VortexAcherontic commented Mar 27, 2023

tim-hm commented Mar 28, 2023

tim-hm commented Apr 6, 2023 • edited

VortexAcherontic commented Apr 12, 2023

rapenne-s commented Apr 12, 2023

khaled-0 commented Apr 19, 2023

RedAuburn commented May 5, 2023 • edited

Kalitsune commented May 26, 2023

khaled-0 commented May 31, 2023

RedAuburn commented Jun 14, 2023

timreach commented Jun 27, 2023

rapenne-s commented Jul 3, 2023

VortexAcherontic commented Jul 3, 2023

VortexAcherontic commented Jul 19, 2023

1e4 commented Jul 26, 2023

FelipeFTN commented Jul 26, 2023

timreach commented Sep 1, 2023

FelipeFTN left a comment

Choose a reason for hiding this comment

tim-hm commented Apr 6, 2023 •

edited

RedAuburn commented May 5, 2023 •

edited