Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generated history events for unchanged custom fields #1930

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vboctor
Copy link
Member

@vboctor vboctor commented Oct 16, 2023

Fixes #22408

@vboctor vboctor self-assigned this Oct 16, 2023
@dregad
Copy link
Member

dregad commented Oct 16, 2023

Have not looked at the code yet, but did you consider the earlier work and discussion in #1035 ?

@atrol
Copy link
Member

atrol commented Oct 16, 2023

Please no late changes for 2.26.0.

Did just one single test and found that editing text custom fields is broken.
E.g. set value to "1", after that try to set value to "1.0".
The value will not be changed.

@vboctor
Copy link
Member Author

vboctor commented Oct 17, 2023

@dregad I have hit the bug, implemented a fix, and then found the issue related to it, so I didn't take into consideration the previous work. I just had a vague memory that this bug was reported before. The bug I hit was that multi-select custom field was always adding history events after editing an issue. That is called because "A|B" is not equals to "A|B|". Hence, I did the trimming calls in history events for such custom field type. I then added the check in the higher level business logic to avoid the write of custom field to the db if there is no change.

Feel free to combine the best of the two PRs or close this one.

@atrol +1 for getting 2.26.0 out as is, and not get more features in. I wasn't assuming this would be part of the release, since @dregad is cutting it soon as per my understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants