Improved filter : none and not empty are available on custom fields a… #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd user fields
This pull request aims to provide a patch for these issues. It adds a new option [not empty] to user field filters and custom filters (except for text area).
0004864: Unable to filter on empty custom field value
0008149: New filter option: [Someone] for Assigned to and other filter fields
0012798: Add a filter option [Something] as opposite of [None] i.e. field not null
(and other closed/duplicate issues that are attached)
I have tried to make the smallest possible changes to the existing code except for one function in core/filter_form_api.php which has been factorized. More improvements could have been made to this class but i didn't want to risk having unwanted behaviours.
I hope the patch will be accepted into the official code and i'm expecting your remarks if additional code improvements are needed.