Add EVENTs to get additionals user attributes from LDAP and show them #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin exemple for use : https://github.com/Association-Cocktail/LdapCacheFields |
|
@vboctor |
dregad
force-pushed
the
maturbet-ldapfieldsevent-1
branch
from
191a3a2
to
5aa5040
Compare
maturbet
force-pushed
the
maturbet-ldapfieldsevent-1
branch
from
c8a68ff
to
298787a
Compare
maturbet
force-pushed
the
maturbet-ldapfieldsevent-1
branch
2 times, most recently
from
c2b75b1
to
6328e50
Compare
maturbet
force-pushed
the
maturbet-ldapfieldsevent-1
branch
from
6328e50
to
791b759
Compare
vboctor
requested changes
Oct 20, 2023
There was a problem hiding this comment.
-
For attributes to display the plugin event should return logical data that is rendered by core. We have been moving away from have events echo html output. Reason is that it is not API friendly and breaks whenever Mantis UI is changed.
-
For the extra LDAP fields, why not just use a config option rather than a plugin event?
-
Should the extra LDAP info be included in the REST API that retrieves user info? eg in ldap_fields element?
I think I can make that change.
I used a plugin event following a past suggestion but I'll use the method you prefer ...
Probably, it makes sense. |
maturbet
force-pushed
the
maturbet-ldapfieldsevent-1
branch
from
791b759
to
6ca6c9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.