Added custom caching for get_spectrum and add ROI handling improvements #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmeigh
changed the title
samtygier-stfc
requested changes
May 14, 2024
| @@ -190,26 +193,201 @@ def normalise_issue(self) -> str: | |||
| return "" | |||
|
|
|||
| def get_spectrum(self, roi: str | SensibleROI, mode: SpecType) -> np.ndarray: | |||
There was a problem hiding this comment.
Can the caching be done in get_stack_spectrum()
| intersection_bottom = min(old_roi.bottom, new_roi.bottom) | ||
|
|
||
| if intersection_right > intersection_left and intersection_bottom > intersection_top: | ||
| old_area = (old_roi.right - old_roi.left) * (old_roi.bottom - old_roi.top) |
There was a problem hiding this comment.
Move area and overlap calculation into SensibleROI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Added custom caching for get_spectrum and added ROI handling improvements
Added a custom caching mechanism using a dictionary in the model
Added methods to manage the cache, including
_roi_to_keyfor converting SensibleROI to hashable keys andclear_cachefor clearing the cache.Improved
get_spectrumto use tacheAdded
Added
Added
calculate_removed_dataandcalculate_added_datacompute data points removed and added when the ROI changes.Updated
update_cached_datato remove and add data into the cached valueTesting
It needs a lot more messing around with to find the errors I have already picked up on a few. Plus other things like thresholds
Acceptance Criteria
Documentation
Updated the documentation in the appropriate file in docs/release_notes to reflect the added functionality for ROI speed optimization.