NaN warnings activated in the Spectrum Viewer #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeSullivan7
force-pushed
the
2185_Spectrum_NaN_detect
branch
from
3174aa0
to
1806759
Compare
MikeSullivan7
force-pushed
the
2185_Spectrum_NaN_detect
branch
from
1806759
to
b01bc1b
Compare
ashmeigh
approved these changes
May 16, 2024
| @@ -113,12 +116,12 @@ class SpectrumWidget(QWidget): | |||
| spectrum_plot_widget: SpectrumPlotWidget | |||
| image_widget: SpectrumProjectionWidget | |||
|
|
|||
| def __init__(self) -> None: | |||
| def __init__(self, parent: MainWindowView) -> None: | |||
There was a problem hiding this comment.
Can we avoid calling this parent here. It has a specific meaning in Qt, and caused issues before. I think best to call it main_window.
There was a problem hiding this comment.
See #1989
The key bit is not passing it to the Qt widget constructor, but still best to call it main_window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2185
Description
In the
SpectrumWidgetclass, the MainWindow is now passed to theSpectrumProjectionWidgetand theBadDataOverlaymixin class is used in theSpectrumProjectionWidget. The warning icon now appears in the Spectrum viewer when a slice which has a NaN in it is shown on the averaged image (as the NaN will propagate). The warning icon retains the same functionality as in the Main Window where it can be clicked on to open the Operations Window such that NaN removal can be performed.Testing
make check
Acceptance Criteria
Documentation
Will add release note