Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute operation Normalising #2126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

compute operation Normalising #2126

wants to merge 1 commit into from

Conversation

ashmeigh
Copy link
Collaborator

@ashmeigh ashmeigh commented Mar 12, 2024

Issue

This issue was part of #2051

Description

This pull request addresses the ongoing effort to standardize the execution of operations by transitioning from the partial function style to a structured compute_function approach. In this update, several operations have been refactored to adhere to the new standard. The modifications ensure a clearer separation between the setup and execution phases of each operation, improving the maintainability and readability of the codebase.

Changes

Refactored multiple operations to implement the new compute_function approach.
Introduced static methods compute_function in each affected operation module to encapsulate the core logic for executing the operation on a per-slice basis.
Updated the calling code to use the compute_function method instead of the previous partial function style

@coveralls
Copy link

Coverage Status

coverage: 72.735%. remained the same
when pulling 1d2def2 on compute_norm
into aa6025b on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants