Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to Manual Testing instructions about missing wavelength tooltips #37319

Merged

Conversation

cailafinn
Copy link
Contributor

Description of work

Summary of work

Add a note to the manual testing instructions about missing tooltips for wavelength in the ISIS SANS GUI.

This is a known issue, but low priority for the SANS group right now.

Fixes #35085

Further detail of work

  • Added a note to not raise an issue during manual testing if the missing tooltips are found.

To test:

  1. Build the dev-docs-html target
  2. Check the docs are formatted correctly when opened in a browser.

This does not require release notes because **it is part of the developer documentation only. **


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@cailafinn cailafinn added SANS Issues and pull requests related to SANS Documentation Issues and pull requests related to documentation ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS labels May 13, 2024
@cailafinn cailafinn added this to the Release 6.11 milestone May 13, 2024
This is a known issue, but low priority for the SANS group right now.

RE mantidproject#35085
@cailafinn cailafinn force-pushed the 35085_wavelength_tooltips_man_test branch from c37f95b to 60f885b Compare May 13, 2024 10:02
@cailafinn cailafinn marked this pull request as ready for review May 13, 2024 10:46
@GuiMacielPereira GuiMacielPereira self-requested a review May 13, 2024 14:36
@GuiMacielPereira GuiMacielPereira self-assigned this May 13, 2024
Copy link
Contributor

@GuiMacielPereira GuiMacielPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built dev-docs-html and confirmed the changes were added successfully

@rbauststfc rbauststfc merged commit 51ce2dd into mantidproject:main May 13, 2024
10 checks passed
@cailafinn cailafinn deleted the 35085_wavelength_tooltips_man_test branch May 14, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS SANS Issues and pull requests related to SANS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ISIS SANS Manual Testing instructions to clarify about missing tooltips for Wavelength section
3 participants