Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new disableReplaceWSButton Property flag. Disable button creation on the WANDPowderReduction algorithm. #37314

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented May 10, 2024

Description of work

This button was confusing users with its behavior not what was expected, particularly when the input was a group workspace. So this disables it for the WANDPowderReduction algorithm. Other algorithms can make use of the same option.

Before:
2024-05-10-131840_494x584_scrot
Now:
2024-05-10-131800_460x583_scrot

Summary of work

Fixes EWM855

Further detail of work

To test:

Open the WANDPowderReduction algorithm dialog and check that button is gone.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@rosswhitfield rosswhitfield added this to the Release 6.10 milestone May 10, 2024
@rosswhitfield rosswhitfield marked this pull request as ready for review May 10, 2024 05:51
@jhaigh0 jhaigh0 changed the base branch from main to release-next May 10, 2024 12:51
@zjmorgan zjmorgan self-requested a review May 10, 2024 21:17
Copy link
Contributor

@zjmorgan zjmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@peterfpeterson peterfpeterson removed their request for review May 10, 2024 21:32
@peterfpeterson peterfpeterson merged commit 2d38088 into mantidproject:release-next May 10, 2024
10 checks passed
@rosswhitfield rosswhitfield deleted the disable_replace_ws_button branch May 12, 2024 23:09
@Kvieta1990
Copy link
Contributor

Thanks a lot for your work on this! @rosswhitfield and for your review! @zjmorgan Really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants