Remove unused include #37310
Open
Remove unused include #37310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilkeSchomann
added
the
Maintenance
This was referenced May 9, 2024
|
This seems to have failed https://builds.mantidproject.org/job/build_packages_from_branch/794/ |
There are probably more files with redundant includes. I guess I have to fix them one by one. |
|
👋 Hi, @SilkeSchomann, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
github-actions
bot
added
the
Has Conflicts
SilkeSchomann
removed
the
Has Conflicts
SilkeSchomann
force-pushed
the
37308_fix_timeroi_to_unpin_libcxx
branch
from
28c7b37
to
7fbfff7
Compare
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @SilkeSchomann, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Removed unused includes and unpin libcxx in the conda recipes for OSX.
Fixes 37308.
Fixes 37355.
To test:
Observe that tests are not failing and code review. This package build should succeed as well: https://builds.mantidproject.org/job/build_packages_from_branch/805/
This does not require release notes because it is not visible to the user.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.