New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Save Other" Widget's Saving in ISIS SANS Interface #37221
Fix "Save Other" Widget's Saving in ISIS SANS Interface #37221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix is working well and great to have some tests added 👍 I agree that adding tests for on_save()
is outside the scope of this PR. If not already done, is it worth adding a maintenance issue for this, though?
I've got just a couple of minor suggestions on documentation/release notes.
Issue for adding more tests created here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All review comments have been addressed and look good, this is ready to be merged in. Thanks for sorting this fix so quickly!
Description of work
Summary of work
Add the additional positional argument to the
save_workspace_to_file
method imported frombatch_execution
in the call from the Save Other widget.Fixes #37219
Further detail of work
This seems not to have been covered by either our unit or manual testing. So appropriate tests have been added to to the docs and code to remedy this.
The unit tests added test the call two-fold. Once to make sure that any future changes to the
save_workspace_to_file
's positional arguments will cause a failure, and the other to make sure any unexpected changes to the call ofsave_workspace_to_file
will also fail.on_save()
was completely untested. There is probably more that could be added, but that's beyond the scope of this PR.To test:
loqdemo
in the training course data.Save Other
.Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.