IntBoundedValidator raises set attribute error

[robertapplin]

Description of work

Using IntBoundedValidator to declare an attribute causes an error:

RuntimeError: Set Attribute Error: Value was not of expected type.

Even though the value provided is a valid type.

The problem was caused by a static cast to an int on line 116 of Algorithm.cpp. The properties type is changed to an int, however the validator is still checking against the long type. The solution I went for was to make sure the validators use int rather than long, and to do a static cast from long to int as soon as possible after crossing from python to c++.

To test:

Check that the IFunction1DValidatorTest test passes

Check that this build from branch passes
https://builds.mantidproject.org/job/build_packages_from_branch/783/

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

• Is the code of an acceptable quality?
• Does the code conform to the coding standards?
• Are the unit tests small and test the class in isolation?
• If there is GUI work does it follow the GUI standards?
• If there are changes in the release notes then do they describe the changes appropriately?
• Do the release notes conform to the release notes guide?

Functional Tests

• Do changes function as described? Add comments below that describe the tests performed?
• Do the changes handle unexpected situations, e.g. bad input?
• Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

[thomashampson]

New tests have been added to expose the problem, and the changes seem to work as intended.