Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Inelastic QENS FitTab #37193

Merged
merged 16 commits into from Apr 30, 2024
Merged

Refactor Inelastic QENS FitTab #37193

merged 16 commits into from Apr 30, 2024

Commits on Apr 24, 2024

  1. Set file extensions using settings helper

    @robertapplin
    robertapplin committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b5b8ae3 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary functions from fit tab

    @robertapplin
    robertapplin committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    7631122 View commit details
    Browse the repository at this point in the history

  3. Move fit string creation to FittingModel

    @robertapplin
    robertapplin committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    25343e2 View commit details
    Browse the repository at this point in the history

  4. Move getDatasets function to FitDataPresenter

    @robertapplin
    robertapplin committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    80c201b View commit details
    Browse the repository at this point in the history

  5. Simplify functions and remove unused functions

    @robertapplin
    robertapplin committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    af4a9cb View commit details
    Browse the repository at this point in the history

  6. Combine Run enabled and fit button enabled functions

    @robertapplin
    robertapplin committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    e20a0fa View commit details
    Browse the repository at this point in the history

  7. Remove unused updateParameterValues function

    @robertapplin
    robertapplin committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4929f31 View commit details
    Browse the repository at this point in the history

  8. Move fit property collection to FitPropertyBrowser

    @robertapplin
    robertapplin committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    6cc77bf View commit details
    Browse the repository at this point in the history

  9. Remove unused executeFit function

    @robertapplin
    robertapplin committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    851c16f View commit details
    Browse the repository at this point in the history

  10. Re-organise FitTab class

    @robertapplin
    robertapplin committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    44d2a95 View commit details
    Browse the repository at this point in the history

  11. Remove unrequired member variables of FitTab class

    @robertapplin
    robertapplin committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    0adadc3 View commit details
    Browse the repository at this point in the history

  12. Tidy up validate method in FitTab

    @robertapplin
    robertapplin committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4b1805e View commit details
    Browse the repository at this point in the history

  13. The order of the functions in the fit string does not matter

    @robertapplin
    robertapplin committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    7c207e3 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Only display warning when error message exists

    @robertapplin
    robertapplin committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    cefac28 View commit details
    Browse the repository at this point in the history

  2. Store tab name in parent widget window title

    @robertapplin
    robertapplin committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    78e8278 View commit details
    Browse the repository at this point in the history

  3. Use std::vector<std::string> instead of QStringList for datasets

    @robertapplin
    robertapplin committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1d257a8 View commit details
    Browse the repository at this point in the history