New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a couple property handler bugs #37186
Conversation
The underlying function does not add a tie to its list of ties if the expression is static. The property handler does not follow this behaviour and adds static ties to m_ties. Therefore, simply checking that getTie returns a nullpointer is not enough to confirm that a tie has been removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and the original crash no longer happens. I just had two questions, then happy to approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for confirming - in that case happy to approve!
Description of work
Initially this work was just to fix #37129, but I also found a bug where all the remaining "Fix" properties would be removed when removing a function from the same composite function.
Summary of work
f0.f0.f0
) could be parsed properly.renameChildren
to see if the parameter is fixed.fix
function so it is all more consistentfix
to calladdTie
which now checks if the tie is static (aka a fix).Fixes #37129
renameChildren
definitely still contains a problem or two. I don't think it copes well if you had a bunch of nested composite function and wanted to tie across different levels, but this isn't a regression, so I will try and fix these in a later pr.To test:
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.