Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add polarizer efficiency algorithm #37180

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Add polarizer efficiency algorithm #37180

wants to merge 14 commits into from
+556 −0

Commits on May 9, 2024

  1. Add algorithm, tests, and docs 

    Calculate polarizer efficiency using a group workspace with
4 runs for the 4 spin combinations, plus the efficiency of the
analyser cell, calculated previously.
    @jclarkeSTFC @rbauststfc
    jclarkeSTFC authored and rbauststfc committed May 9, 2024
    Configuration menu
    Copy the full SHA
    b31b9eb View commit details
    Browse the repository at this point in the history

  2. Fix doc test

    @jclarkeSTFC @rbauststfc
    jclarkeSTFC authored and rbauststfc committed May 9, 2024
    Configuration menu
    Copy the full SHA
    36fa2b7 View commit details
    Browse the repository at this point in the history

  3. Update to use new formula for efficiency

    @jclarkeSTFC @rbauststfc
    jclarkeSTFC authored and rbauststfc committed May 9, 2024
    Configuration menu
    Copy the full SHA
    8d8bc85 View commit details
    Browse the repository at this point in the history

  4. Pre-emptive attack on Coverity

    @jclarkeSTFC @rbauststfc
    jclarkeSTFC authored and rbauststfc committed May 9, 2024
    Configuration menu
    Copy the full SHA
    65db887 View commit details
    Browse the repository at this point in the history

  5. Tidy up code 

    Missing const in a few places, deleted unneeded methods and used the
operator overloads instead.
    @jclarkeSTFC @rbauststfc
    jclarkeSTFC authored and rbauststfc committed May 9, 2024
    Configuration menu
    Copy the full SHA
    909639d View commit details
    Browse the repository at this point in the history

  6. Update formula for polarizer efficiency 

    Includes updating expected test results
    @jclarkeSTFC @rbauststfc
    jclarkeSTFC authored and rbauststfc committed May 9, 2024
    Configuration menu
    Copy the full SHA
    11e1794 View commit details
    Browse the repository at this point in the history

  7. Fix cppcheck

    @jclarkeSTFC @rbauststfc
    jclarkeSTFC authored and rbauststfc committed May 9, 2024
    Configuration menu
    Copy the full SHA
    5096c96 View commit details
    Browse the repository at this point in the history

  8. Update equations in docs

    @jclarkeSTFC @rbauststfc
    jclarkeSTFC authored and rbauststfc committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d400136 View commit details
    Browse the repository at this point in the history

  9. Add option to save to file 

    You can now either have an output workspace, or save to a file, or both.
    @jclarkeSTFC @rbauststfc
    jclarkeSTFC authored and rbauststfc committed May 9, 2024
    Configuration menu
    Copy the full SHA
    9db3f69 View commit details
    Browse the repository at this point in the history

  10. Specify input is a workspace group 

    Co-authored-by: Caila Finn <47181718+cailafinn@users.noreply.github.com>
    @jclarkeSTFC @cailafinn @rbauststfc
    2 people authored and rbauststfc committed May 9, 2024
    Configuration menu
    Copy the full SHA
    bab74fa View commit details
    Browse the repository at this point in the history

  11. Input may not be in the ADS 

    Co-authored-by: Caila Finn <47181718+cailafinn@users.noreply.github.com>
    @jclarkeSTFC @cailafinn @rbauststfc
    2 people authored and rbauststfc committed May 9, 2024
    Configuration menu
    Copy the full SHA
    48c6cfd View commit details
    Browse the repository at this point in the history

  12. Remove validator on input workspace 

    This validator does not work when the type is specified explicitly as
being a WorkspaceGroup, so instead we'll have to to check for wavelength
in validateInputs().
    @jclarkeSTFC @rbauststfc
    jclarkeSTFC authored and rbauststfc committed May 9, 2024
    Configuration menu
    Copy the full SHA
    153d06d View commit details
    Browse the repository at this point in the history

  13. Add note about rebinning to documentation

    @rbauststfc
    rbauststfc committed May 9, 2024
    Configuration menu
    Copy the full SHA
    387fd4e View commit details
    Browse the repository at this point in the history

  14. Minor refactoring

    @rbauststfc
    rbauststfc committed May 9, 2024
    Configuration menu
    Copy the full SHA
    19babc8 View commit details
    Browse the repository at this point in the history