Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to find peaks using ratio variance/ mean in FindSXPeaksConvolve #37171

Merged
merged 10 commits into from May 2, 2024
Merged

Add option to find peaks using ratio variance/ mean in FindSXPeaksConvolve #37171

merged 10 commits into from May 2, 2024

Commits on Apr 11, 2024

  1. Add variance over mean ratio to FindSXPEaksConvolve 

    For a constant background the Poisson distributed counts should have Variance = mean (i.e. ratio = 1) - in the region of a Bragg peak the variance/mean > 1.
This idea is taken from DIALS software package for x-ray diffraction as described Winter (2018) https://doi.org/10.1107/S2059798317017235 - generalised to 3D TOF Laue
    @RichardWaiteSTFC
    RichardWaiteSTFC committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    6265ae7 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Implement usign 1D convolutions (with uniform_filter) for performance

    @RichardWaiteSTFC
    RichardWaiteSTFC committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    e26041d View commit details
    Browse the repository at this point in the history

  2. Add argument doc strings and refactor to reduce size of main exec

    @RichardWaiteSTFC
    RichardWaiteSTFC committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    eb641f7 View commit details
    Browse the repository at this point in the history

  3. Add unit test

    @RichardWaiteSTFC
    RichardWaiteSTFC committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    917cf2c View commit details
    Browse the repository at this point in the history

  4. Use FindSXPeaksConvolve as default in sxd and update system test

    @RichardWaiteSTFC
    RichardWaiteSTFC committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    a842637 View commit details
    Browse the repository at this point in the history

  5. Update documentation

    @RichardWaiteSTFC
    RichardWaiteSTFC committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    0e6c186 View commit details
    Browse the repository at this point in the history

  6. Add release notes

    @RichardWaiteSTFC
    RichardWaiteSTFC committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    396ca19 View commit details
    Browse the repository at this point in the history

  7. Fix typo in docs

    @RichardWaiteSTFC
    RichardWaiteSTFC committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    dfd02fb View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Remove unnecessary reference file to avoid flaky tests 

    Test passes on windows not on jenkins linux, asserts test the functionality sufficiently
    @RichardWaiteSTFC
    RichardWaiteSTFC committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9560824 View commit details
    Browse the repository at this point in the history

  2. Update technique docs as per PR review

    @RichardWaiteSTFC
    RichardWaiteSTFC committed May 1, 2024
    Configuration menu
    Copy the full SHA
    f653bed View commit details
    Browse the repository at this point in the history