Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues for masOS Sonoma 14.4 #37124

Merged

Conversation

cailafinn
Copy link
Contributor

@cailafinn cailafinn commented Apr 5, 2024

The latest macOS update seems to have moved AuthorizationRef, so add the extra include to allow it to build properly.

There is no associated issue.

To test:

  1. This might need testing by the ILL on macOS to ensure that the proxy still performs as expected.

This does not require release notes because it only fixes a build issue and should not be user-facing.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

The latest macOS update seems to have moved AuthorizationRef, so add the
extra include to allow it to build properly.
@cailafinn cailafinn added the macOS Only The issues related to macOS only. label Apr 5, 2024
@cailafinn cailafinn marked this pull request as ready for review April 16, 2024 09:36
@perenon
Copy link
Contributor

perenon commented Apr 30, 2024

Hi Caila.
Thank you for paying close attention to potential issue with ILL :-) .

As discussed with Sarah on Slack, my opinion would be to merge it if you were able to test on your side.

Regards,
Remi

Copy link
Contributor

@SilkeSchomann SilkeSchomann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have built Mantid successfully from this branch and tested that Mantid Workbench is still behaving normally. To check that authorisation still works, I've run the example script for ISISJournalGetExperimentRuns from the documentation and it worked fine.

@SilkeSchomann SilkeSchomann self-assigned this May 1, 2024
@robertapplin robertapplin merged commit e31eb0a into mantidproject:main May 1, 2024
9 checks passed
@cailafinn cailafinn deleted the macOS_fix_build_sonoma_14_4 branch May 1, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macOS Only The issues related to macOS only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants