Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick for 6.9.1 patch release #37055

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

thomashampson
Copy link
Contributor

@thomashampson thomashampson commented Mar 21, 2024

Description of work

Contains the commits for work that was requested to go into the v6.9.1 patch release, but were previously merged into main, but with the release notes omitted.

Purpose of work

To move these two pieces of work ahead into the patch release:
#36935
#37016

The issues were already closed because the commits are already in main

To test:

Verify that the commits are those required.

This does not require release notes because they are in a separate PR


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@thomashampson thomashampson marked this pull request as ready for review March 21, 2024 16:59
@thomashampson thomashampson added this to the Release 6.9.1 milestone Mar 21, 2024
@thomashampson thomashampson added the Patch Candidate Urgent issues that must be included in a patch following a release label Mar 21, 2024
Copy link
Contributor

@robertapplin robertapplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elwin changes look right

Copy link
Contributor

@rbauststfc rbauststfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for this!

@thomashampson thomashampson merged commit 78313e9 into release-next Mar 22, 2024
9 checks passed
@thomashampson thomashampson deleted the add_commits_to_6_9_1_release branch March 22, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Patch Candidate Urgent issues that must be included in a patch following a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants