Replace draw with draw_idle for some functions #37052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In figuremanager.py replace canvas.draw with canvas.draw_idle() for - replaceHandle - renameHandle - deleteHandle To improve plotting especially on Linux
jhaigh0
approved these changes
Mar 21, 2024
thomashampson
added
Patch Candidate
|
doc test failure will be fixed by #37053 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Replacing canvas.draw() with canvas.draw_idle() to improve plotting performance.
Summary of work
In figuremanager.py replace canvas.draw with canvas.draw_idle() in the functions:-
Purpose of work
This is the first step to trying to resolve the issues as outlined in #37030 . It is one of the suggestions that has been made by super users. Initial testing suggests it will definitely make a difference but more testing with users is needed before we can say the original issue is resolved.
The plan is to test this a bit more and then get it merged in to see if it reduces the crashes being reported through Error Reporter.
Report to: see issue #37030 for more details
Notes from Jonathan/Core team
We think this PR will solve a lot of the plotting problems but not those described in #37030 which is based around the quantity of data plotted, we've seen similar problems in older version.
I have written up #37046 to describe the issue this PR will fix
To test:
See #37046
Fixes #37046
This does not require release notes because it is anticiapted more will need to be done to resolve the original issue and a release note for overall improvements will be added then.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.