Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide compatibility for backups pre-6.9 #36914

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

jclarkeSTFC
Copy link
Contributor

Provide compatibility for backups pre-6.9

Summary of work

If the new backup file is not detected, then use the old code for loading backups.

Allows 6.8 backups (and earlier versions) to work in 6.9.
Fixes #36900

To test:

See #36859 for further details.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@jclarkeSTFC jclarkeSTFC added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS labels Feb 22, 2024
@jclarkeSTFC jclarkeSTFC added this to the Release 6.9 milestone Feb 22, 2024
@jclarkeSTFC jclarkeSTFC marked this pull request as ready for review February 22, 2024 10:27
@jhaigh0 jhaigh0 self-assigned this Feb 22, 2024
Copy link
Contributor

@jhaigh0 jhaigh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When loading a 6.9 recovery in 6.8, I experienced the bug where Mantid runs the old cached version of ordered_recovery.py. I checked to make sure the right script had been generated by opening the file else where and it had. Not much we can do about that bug.

Everything else worked as expected

Copy link
Contributor

@thomashampson thomashampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the new bug where mantid 6.9.0 wouldn't open after a 6.8.0 crash, and also improves the functionality so that project recovery is compatible in both directions (6.9 -> pre-6.9 and vice versa).

@thomashampson thomashampson merged commit 66c74f8 into release-next Feb 22, 2024
8 of 9 checks passed
@thomashampson thomashampson deleted the project_recovery_fix branch February 22, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants