Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release note for project recovery improvement #36896

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

thomashampson
Copy link
Contributor

Description of work

This will potentially be visible to users so needs a release note.

There is no associated issue.

To test:

Proof read.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@thomashampson thomashampson added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Documentation Issues and pull requests related to documentation labels Feb 20, 2024
@thomashampson thomashampson added this to the Release 6.9 milestone Feb 20, 2024
@thomashampson thomashampson marked this pull request as ready for review February 20, 2024 12:30
Copy link
Contributor

@sf1919 sf1919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a useful release note and really should be in v6.9.

@SilkeSchomann SilkeSchomann merged commit 0c0d235 into release-next Feb 20, 2024
9 checks passed
@SilkeSchomann SilkeSchomann deleted the release-note-project-recovery branch February 20, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

4 participants