Increase auto-processing timeout in ISIS Reflectometry GUI #36895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Summary of work
This is causing quite a bit of inconvenience on IDAaaS at the moment, so this is a quick and temporary fix to try and alleviate that. Increasing the interval at which we're polling for new runs should allow time for the data to be copied into the instrument data cache and available for reduction. Currently about 50% of runs are appearing in the Reflectometry GUI before the file is available and this is causing auto-processing to stall, creating confusion.
Longer term we will put a fix in place so that the GUI is fundamentally more robust to timing issues with files becoming available.
Refs #36860.
Further detail of work
To test:
It's difficult to test this with live data from an instrument as part of a quick PR test (although I have tested this locally), but the following will confirm that the functionality is still working:
1120015
and cycle11_3
.This does not require release notes because it is a temporary fix that will be superseded by a more complete fix in future.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.