Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin conda-build to 3.28.4 #36864

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

SilkeSchomann
Copy link
Contributor

@SilkeSchomann SilkeSchomann commented Feb 19, 2024

Description of work

Summary of work

I think we need to pin this to 3.28.4 to avoid problems with conda index.

To test:

Observe the branch builds properly: https://builds.mantidproject.org/job/build_packages_from_branch/748/

This does not require release notes because this is not visible to an external user


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@SilkeSchomann SilkeSchomann marked this pull request as ready for review February 19, 2024 16:35
@jhaigh0
Copy link
Contributor

jhaigh0 commented Feb 19, 2024

Can we make sure there's an issue to unpin conda-build?

Copy link
Contributor

@jhaigh0 jhaigh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this should be pointed into release-next

@jhaigh0 jhaigh0 changed the base branch from main to release-next February 19, 2024 18:33
@jhaigh0
Copy link
Contributor

jhaigh0 commented Feb 19, 2024

Seemed to be an unrelated test failure on Linux, trying a rerun...

@robertapplin robertapplin merged commit 4df8151 into release-next Feb 20, 2024
9 checks passed
@robertapplin robertapplin deleted the check_unpin_conda_build branch February 20, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants