-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing inelastic interface screenshots #36846
Merged
SilkeSchomann
merged 5 commits into
mantidproject:release-next
from
robertapplin:0-fix-inelastic-interface-screenshots
Feb 15, 2024
Merged
Fix missing inelastic interface screenshots #36846
SilkeSchomann
merged 5 commits into
mantidproject:release-next
from
robertapplin:0-fix-inelastic-interface-screenshots
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertapplin
added
Documentation
Issues and pull requests related to documentation
Indirect/Inelastic
Issues and pull requests related to indirect or inelastic
ISIS Team: Spectroscopy
Issue and pull requests managed by the Spectroscopy subteam at ISIS
labels
Feb 14, 2024
robertapplin
force-pushed
the
0-fix-inelastic-interface-screenshots
branch
from
February 14, 2024 13:12
3a83932
to
0bd538c
Compare
adriazalvarez
requested changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. Thanks for the fix.
I have pointed out some missing corrected lines in one file.
adriazalvarez
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Documentation
Issues and pull requests related to documentation
Indirect/Inelastic
Issues and pull requests related to indirect or inelastic
ISIS Team: Spectroscopy
Issue and pull requests managed by the Spectroscopy subteam at ISIS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This PR fixes an issue where the screenshots for the Inelastic Bayes fitting interface and the Inelastic Settings widget were missing.
I decided to just remove the image for the Settings widget because it is no longer an interface, and an image of it would not be particularly useful.
The Data Analysis image is outdated - it would be better to use an automatic screenshot.
Fixes #36844
To test:
Build the docs locally with
DOCS_SCREENSHOTS
turned on.Check that the html files in the build folder for the bayes fitting and data analysis interface have their screenshots.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.