Clean up Inelastic release notes #36833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertapplin
added
the
Documentation
backmari
reviewed
Feb 9, 2024
| @@ -8,36 +8,41 @@ Inelastic Changes | |||
| New Features | |||
| ------------ | |||
| - The :ref:`Interface Settings <interface-indirect-settings>` has a new advanced option called ``Developer Feature Flags``. When developing a large new feature, developers will create a flag that can be used by advanced software users for purposes of rapid prototyping and allowing a faster feedback loop. | |||
There was a problem hiding this comment.
I see that the link points to something under "Indirect". Do Indirect and Inelastic share this feature? Sorry, don't know this area at all!
There was a problem hiding this comment.
Good spot, yes you are right that both Indirect and Inelastic interface categories share a common settings widget. This link for the settings page is however a bit outdated because it suggests that the settings widget is only used by indirect. I have updated the link to a better name inelastic-interface-settings. This is a better description because inelastic encompasses indirect, whereas indirect does not encompass all of inelastic (we can also have direct inelastic)!
backmari
previously approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This PR does some cleanup for the Inelastic release notes so they are ready for the release of Mantid v6.9.
To test:
Read through the Inelasitc release notes to make sure they make sense/no typos. Build the docs to check the image is displaying correctly.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.