Description of work

Summary of work

Add the additional positional argument to the save_workspace_to_file method imported from batch_execution in the call from the Save Other widget.

Fixes #37219

Further detail of work

This seems not to have been covered by either our unit or manual testing. So appropriate tests have been added to to the docs and code to remedy this.

The unit tests added test the call two-fold. Once to make sure that any future changes to the save_workspace_to_file's positional arguments will cause a failure, and the other to make sure any unexpected changes to the call of save_workspace_to_file will also fail.

on_save() was completely untested. There is probably more that could be added, but that's beyond the scope of this PR.

To test:

1. Open the ISIS SANS Interface
2. Load the batch and user files from the loqdemo in the training course data.
3. Process one of the rows.
4. Click Save Other.
5. In the widget, select one of the generated output workspaces.
6. Provide a file name and a save path
7. Click Save.
8. No errors should appear (note that attempting to save a non-reduced workspace will produce an error, but this is expected and the error message should be reasonably clear to indicate this.)

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

• Is the code of an acceptable quality?
• Does the code conform to the coding standards?
• Are the unit tests small and test the class in isolation?
• If there is GUI work does it follow the GUI standards?
• If there are changes in the release notes then do they describe the changes appropriately?
• Do the release notes conform to the release notes guide?

Functional Tests

• Do changes function as described? Add comments below that describe the tests performed?
• Do the changes handle unexpected situations, e.g. bad input?
• Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.