Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unex When Using Save Other Window In ISIS SANS Interface #37219

Closed
2 of 3 tasks
cailafinn opened this issue Apr 25, 2024 · 0 comments · Fixed by #37221
Closed
2 of 3 tasks

Unex When Using Save Other Window In ISIS SANS Interface #37219

cailafinn opened this issue Apr 25, 2024 · 0 comments · Fixed by #37221
Assignees
Labels
Added during Sprint Tasks that were added after initial sprint planning Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS SANS Issues and pull requests related to SANS
Milestone

Comments

@cailafinn
Copy link
Contributor

cailafinn commented Apr 25, 2024

Describe the bug
An unhandled exception occurs when using the "Save Other" window in the ISIS SANS GUI.

Seems to be as a result of the additional metadata being added. Poor test coverage meant it got through unnoticed this long.

To Reproduce

  1. Run anything through the ISIS SANS GUI (loqdemo)
  2. Click Save Other and save one of the output workspaces
  3. Crash.

Expected behavior

  • File is saved correctly.
  • Test coverage is added to detect when issues like this occur.
  • Manual testing instructions are present to test this widget.

Platform/Version (please complete the following information):

  • OS: All
  • OS Version: N/A
  • Mantid Version 6.9.1

Additional context
Traceback:

Traceback (most recent call last):
File "C:\MantidInstall\scripts\Interface\ui\sans_isis\SANSSaveOtherWindow.py", line 63, in on_save_clicked
subscriber.on_save_clicked()
File "C:\MantidInstall\scripts\SANS\sans\gui_logic\presenter\save_other_presenter.py", line 49, in on_save_clicked
save_workspace_to_file(name_to_save, file_formats, filename, additional_run_numbers)
TypeError: save_workspace_to_file() missing 1 required positional argument: 'additional_metadata'
@cailafinn cailafinn added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) SANS Issues and pull requests related to SANS ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Added during Sprint Tasks that were added after initial sprint planning labels Apr 25, 2024
@cailafinn cailafinn added this to the Release 6.10 milestone Apr 25, 2024
@cailafinn cailafinn self-assigned this Apr 25, 2024
cailafinn added a commit to cailafinn/mantid that referenced this issue Apr 25, 2024
cailafinn added a commit to cailafinn/mantid that referenced this issue Apr 25, 2024
cailafinn added a commit to cailafinn/mantid that referenced this issue Apr 25, 2024
cailafinn added a commit to cailafinn/mantid that referenced this issue Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added during Sprint Tasks that were added after initial sprint planning Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS SANS Issues and pull requests related to SANS
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant