Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MultiFunctionTemplate classes for MSDFit and FQFit tabs #37191

Open
Tracked by #37230
robertapplin opened this issue Apr 19, 2024 · 0 comments
Open
Tracked by #37230

Use MultiFunctionTemplate classes for MSDFit and FQFit tabs #37191

robertapplin opened this issue Apr 19, 2024 · 0 comments
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.

Comments

@robertapplin
Copy link
Contributor

robertapplin commented Apr 19, 2024 •
edited

Blocked by #37190

Description:
We should try re-use code where possible. The MultiFunctionTemplate classes are almost generic enough for them to be used in the MSDFit and FQFit tabs of Inelastic QENS Fitting. When we switch to using these classes, we can remove the SingleFunctionTemplate classes. Reducing the amount of code will reduce the maintenance burden.

Acceptance Criteria

  • MSDFit and FQFit both use the MultiFunctionTemplate classes
  • SingleFunctionTemplate classes have been deleted
@robertapplin robertapplin added ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Indirect/Inelastic Issues and pull requests related to indirect or inelastic Maintenance Unassigned issues to be addressed in the next maintenance period. labels Apr 19, 2024
@robertapplin robertapplin mentioned this issue Apr 26, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
ISIS Spectroscopy
Status: Blocked
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robertapplin