Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inelastic QENS Fitting interface refactor #37230

Open
4 tasks
Tracked by #37229
robertapplin opened this issue Apr 26, 2024 · 0 comments
Open
4 tasks
Tracked by #37229

Inelastic QENS Fitting interface refactor #37230

robertapplin opened this issue Apr 26, 2024 · 0 comments
Labels
Epic Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.

Comments

@robertapplin
Copy link
Contributor

robertapplin commented Apr 26, 2024

Description

The Inelastic QENS Fitting interface is by far one of the better Indirect/Inelastic interfaces in terms of code quality and maintainability. Its structure largely uses the MVP pattern to compartmentalise the Qt Framework and separate it from the logic stored in the model. As a consequence, the QENS Fitting interface has a large number of automated tests, and is easier to extend and maintain.

However, there are still a number of issues that can make a big improvement to the quality of this code.

Plan

@robertapplin robertapplin added ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Indirect/Inelastic Issues and pull requests related to indirect or inelastic Maintenance Unassigned issues to be addressed in the next maintenance period. Epic labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Status: In Progress
Development

No branches or pull requests

1 participant