Cherry-pick pull request #18979

Refs #18978 Update dock when config changes

(cherry picked from commit b54bdfb)

Refs #18978 Set confirmations on startup

(cherry picked from commit eca83cf)

Refs #18978 Emit modified signal when settings are read.

(cherry picked from commit f694b70)

Add patch release note

MantidPlot/src/ApplicationWindow.cpp

@@ -5338,6 +5338,8 @@ void ApplicationWindow::readSettings() {
   settings.endGroup();
   settings.endGroup();
   // END Mantid Muon interface one time only change
+
+  emit configModified();
 }
 
 void ApplicationWindow::saveSettings() {

MantidPlot/src/ApplicationWindow.h

@@ -1123,6 +1123,7 @@ public slots:
 signals:
   void modified();
   void shutting_down();
+  void configModified();
 
 protected:
   bool event(QEvent *e) override;

MantidPlot/src/ConfigDialog.cpp

@@ -2690,6 +2690,7 @@ void ConfigDialog::apply() {
 
   // MD Plotting
   updateMdPlottingSettings();
+  emit app->configModified();
 }
 
 /**

MantidPlot/src/Mantid/MantidUI.cpp

@@ -216,6 +216,8 @@ MantidUI::MantidUI(ApplicationWindow *aw)
 
   m_exploreMantid = boost::make_shared<QWorkspaceDockView>(this, aw);
   m_exploreMantid->init();
+  m_exploreMantid->enableDeletePrompt(
+      appWindow()->isDeleteWorkspacePromptEnabled());
   m_exploreAlgorithms = new AlgorithmDockWidget(this, aw);
 
   actionCopyRowToTable = new QAction(this);
@@ -292,6 +294,8 @@ MantidUI::MantidUI(ApplicationWindow *aw)
   connect(menuMantidMatrix, SIGNAL(aboutToShow()), this,
           SLOT(menuMantidMatrixAboutToShow()));
 
+  connect(m_appWindow, SIGNAL(configModified(void)), this,
+          SLOT(configModified(void)));
   init();
 }
 
@@ -2695,6 +2699,11 @@ void MantidUI::formatLogName(QString &label, const QString &wsName) {
   }
 }
 
+void MantidUI::configModified() {
+  m_exploreMantid->enableDeletePrompt(
+      appWindow()->isDeleteWorkspacePromptEnabled());
+}
+
 std::string MantidUI::extractLogTime(Mantid::Kernel::DateAndTime value,
                                      bool useAbsoluteDate,
                                      Mantid::Kernel::DateAndTime start) {

MantidPlot/src/Mantid/MantidUI.h

@@ -560,6 +560,8 @@ public slots:
 #endif
 
 private slots:
+  // respond to the global Mantid properties being modifed
+  void configModified();
 
   // slot for file open dialogs created from the main app menu, or the
   // workspaces dock window

docs/source/release/v3.9.1/index.rst

@@ -40,6 +40,7 @@ Changes in this version
 * `18955 <https://www.github.com/mantidproject/mantid/pull/18955>`_ Fix crash in MonitorDlg
 * `18959 <https://www.github.com/mantidproject/mantid/pull/18959>`_ Blank instrument view with U correction
 * `18972 <https://www.github.com/mantidproject/mantid/pull/18972>`_ Fix reading dead time data in Muon interface
+* `18979 <https://www.github.com/mantidproject/mantid/pull/18979>`_ Fix delete confirmations in workspace dock
 
 Summary of impact
 -----------------
@@ -80,6 +81,8 @@ Summary of impact
 +-------+-----------------------------------------------------------------------------------+---------------------------------------------+--------------+
 | 18972 | Loads data with/without dead-time correction as per user request                  | Clear data cache after option is updated    | **low**      |
 +-------+-----------------------------------------------------------------------------------+---------------------------------------------+--------------+
+| 18979 | Brings back delete confirmation dialog on removing workspace                      | Propagate setting to relevant objects       | **medium**   |
++-------+-----------------------------------------------------------------------------------+---------------------------------------------+--------------+
 
 .. _download page: http://download.mantidproject.org