Pass bool by value

mantidproject · May 10, 2024 · 8a4ed15 · 8a4ed15
1 parent 5046005
commit 8a4ed15
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Framework/API/inc/MantidAPI/FileFinder.h b/Framework/API/inc/MantidAPI/FileFinder.h
@@ -50,7 +50,7 @@ class MANTID_API_DLL FileFinderImpl {
   std::vector<std::string> findRuns(const std::string &hintstr, const std::vector<std::string> &exts = {},
                                     const bool useExtsOnly = false) const;
   /// DO NOT USE! MADE PUBLIC FOR TESTING ONLY.
-  const Kernel::InstrumentInfo getInstrument(const std::string &hint, const bool &returnDefaultIfNotFound = true) const;
+  const Kernel::InstrumentInfo getInstrument(const std::string &hint, const bool returnDefaultIfNotFound = true) const;
   /// DO NOT USE! MADE PUBLIC FOR TESTING ONLY.
   std::string getExtension(const std::string &filename, const std::vector<std::string> &exts) const;
   void getUniqueExtensions(const std::vector<std::string> &extensionsToAdd, std::vector<std::string> &uniqueExts) const;

diff --git a/Framework/API/src/FileFinder.cpp b/Framework/API/src/FileFinder.cpp
@@ -140,7 +140,7 @@ std::string FileFinderImpl::extractAllowedSuffix(std::string &userString) const
  * @return This will return the default instrument if it cannot be determined.
  */
 const Kernel::InstrumentInfo FileFinderImpl::getInstrument(const string &hint,
-                                                           const bool &returnDefaultIfNotFound) const {
+                                                           const bool returnDefaultIfNotFound) const {
   if ((!hint.empty()) && (!isdigit(hint[0]))) {
     string instrName(hint);
     Poco::Path path(instrName);