Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A test commit #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

A test commit #2

wants to merge 1 commit into from

Conversation

robertapplin
Copy link
Collaborator

Description of work

Purpose of work

Summary of work

Further detail of work

To test:

Fixes #xxxx.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Are the release notes saved in a separate file, using Issue or PR number for file name and in the correct location?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@robertapplin robertapplin force-pushed the 0-rob-test-branch branch 3 times, most recently from 46ad443 to 4fcf781 Compare January 9, 2024 14:38
@robertapplin robertapplin force-pushed the 0-rob-test-branch branch 7 times, most recently from 0fc952c to 0e3b6e1 Compare March 29, 2024 18:51
@robertapplin robertapplin force-pushed the 0-rob-test-branch branch 9 times, most recently from 893e07c to dfa647d Compare April 30, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant