Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to trigger webhook #1

Closed
wants to merge 42 commits into from
Closed

PR to trigger webhook #1

wants to merge 42 commits into from

Conversation

MialLewis
Copy link
Collaborator

Description of work

Purpose of work

Summary of work

Further detail of work

To test:

Fixes #xxxx.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Are the release notes saved in a separate file, using Issue or PR number for file name and in the correct location?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

Copy link

👋 Hi, @MialLewis,

Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

robertapplin pushed a commit that referenced this pull request Jan 9, 2024
Copy link

This pull request has been automatically marked as stale because it has not had activity in 3 months. It will be closed in 7 days if no further activity occurs.
Allowing pull requests to close as stale helps us filter out old work that is no longer relevant and helps developers focus on reviewing current work.
All pull requests closed by this bot act like normal pull requests; they can be searched for, commented on or reopened at any point.
If these changes are still relevant then please comment and tag @mantidproject/gatekeepers to highlight that it needs to have a reviewer assigned.

@github-actions github-actions bot added the Stale label Feb 14, 2024
@robertapplin
Copy link
Collaborator

Not stale

@github-actions github-actions bot removed the Stale label Feb 15, 2024
Copy link

This pull request has been automatically marked as stale because it has not had activity in 3 months. It will be closed in 7 days if no further activity occurs.
Allowing pull requests to close as stale helps us filter out old work that is no longer relevant and helps developers focus on reviewing current work.
All pull requests closed by this bot act like normal pull requests; they can be searched for, commented on or reopened at any point.
If these changes are still relevant then please comment and tag @mantidproject/gatekeepers to highlight that it needs to have a reviewer assigned.

@github-actions github-actions bot added the Stale label May 15, 2024
Copy link

This pull request has been closed automatically. If these changes are still relevant then please re-open this pull request with a comment and tag @mantidproject/gatekeepers to highlight it needs to have a reviewer assigned.

@github-actions github-actions bot closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants