Edit code while running #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the slack hook to an empty string is the easiest way to disable to hook for testing.
The old script stomped on .env files and did no cleanup. The new script uses and existing .env/DB if it exists and generates one a .env file if not. If a .env file and DB did not exist then they are cleaned at the end. Services are also only booted if they are not already running.
Arguments are passed directly to python manage.py test command
don't have wait
Set a default DEBUG value to avoid compose warning
A volume is used for this now.
The postgres container chowns the bind mounted directory and this can then require sudo to remove on the host. Users will need to remove pgdata by hand if they want to.
This works in the case that we don't own the DB directory.
These are the only files that need sharing with the nginx container. This will allow is to mount the code inside container and edit in while the services are running without having to shutdown and rebuild the web image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #54 first.
Minor changes to allow mounting the source code directly into the container to allow editing of the Python code while the containers are running.
Testing
I have updated
DevelopmentSetup.mddocs. Try to follow the instructions and create the override file then run the services.To test if editing it works:
bin/boot.shscriptdocker-compose exec web sh -c "python manage.py test"to check the change has been reflected