Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update check for Unicode support #144

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

norweeg
Copy link

@norweeg norweeg commented Mar 7, 2020

Description of new feature, or changes

removes unnecessary system check for Unicode output
changes Unicode support check to instead use the encoder supported by sys.stdout to try to encode a Unicode character. If it succeeds, Unicode is supported, otherwise it is not

resolves #5
resolves #25
resolves #141
obsoletes #142

see #5 (comment)

Checklist

  • Your branch is up-to-date with the base branch
  • You've included at least one test if this is a new feature
  • All tests are passing

Related Issues and Discussions

People to notify

@coveralls
Copy link

Pull Request Test Coverage Report for Build 432

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 429: 0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@norweeg norweeg changed the title remove unnecessary system check for Unicode output update check for Unicode support Apr 2, 2023
@norweeg
Copy link
Author

norweeg commented Apr 2, 2023

@manrajgrover can you take a look at this?? AppVeyor is failing not on my code change, but at the environment setup for Python 3.7. It can't install pywinpyt which must be a dependency of something required for testing because a Go compiler is not installed on the test server. I believe once that problem is resolved, all tests will pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spinner overwritten in Jupyter on Windows emojis not show Improve Windows Support
2 participants