Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{Issue #59} : stop_and_persist function works as it should #133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

{Issue #59} : stop_and_persist function works as it should #133

wants to merge 2 commits into from

Conversation

hafiz703
Copy link

@hafiz703 hafiz703 commented Oct 21, 2019 •
edited

Description of new feature, or changes

Issue #59 Output gets hidden on stop_and_persist in Jupyter notebooks - added output to self.output.outputs instead of reassignment to persist output when cell finishes running.

Checklist

  • Your branch is up-to-date with the base branch
  • You've included at least one test if this is a new feature
  • All tests are passing

Related Issues and Discussions

Fixes #59

@hafiz703
Update halo.py to fix issue manrajgrover#59
0de14ff 
Output gets hidden on stop_and_persist in Jupyter notebooks - added output to self.output.outputs instead of reassignment to persist output when cell finishes running.
@coveralls
Copy link

coveralls commented Oct 21, 2019 •
edited

Pull Request Test Coverage Report for Build 423

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 422: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

@hafiz703 hafiz703 changed the title BUG FIX ISSUE #59 : stop_and_persist function works as it should {Issue #59} : stop_and_persist function works as it should Oct 22, 2019
@manrajgrover manrajgrover self-requested a review November 13, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manrajgrover manrajgrover Awaiting requested review from manrajgrover

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Output gets hidden on stop_and_persist in Jupyter notebooks
3 participants
@hafiz703 @coveralls @manrajgrover