Fields in table representation #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…field as ul or table
… the fields in table
soraphis
reviewed
Jan 25, 2018
rest_framework_docs/api_endpoint.py
Outdated
| @@ -122,7 +122,8 @@ def __get_serializer_fields__(self, serializer): | |||
| "type": str(field.__class__.__name__), | |||
| "sub_fields": sub_fields, | |||
| "required": field.required, | |||
| "to_many_relation": to_many_relation | |||
| "to_many_relation": to_many_relation, | |||
| "max_length": (field.__dict__.get('max_length', '-') if field.__dict__.get('max_length', '-') != None else '-') | |||
There was a problem hiding this comment.
change:
if field.__dict__.get('max_length', '-') != None else '-')
to
if field.__dict__.get('max_length', '-') is not None else '-')
(to fulfill flake8 requirements)
There was a problem hiding this comment.
Committed the changes for flake8 requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I have added the feature of fields with the table representation. So you can use Table representation to make your fields list in the documentation clear. So We can change representation by adding single line inside the
REST_FRAMEWORK_DOCSinsettings.py. And also showmax_lengthfield in table representation. Sample output I attached here.