Skip to content

Commit

Permalink
Fix Dockerfile (currently broken as there is no jovyan group)
Browse files Browse the repository at this point in the history
  • Loading branch information
manics committed Oct 22, 2023
1 parent 024ab7d commit 6a7204b
Show file tree
Hide file tree
Showing 2 changed files with 47 additions and 6 deletions.
42 changes: 42 additions & 0 deletions .github/workflows/build.yaml
@@ -0,0 +1,42 @@
# This is a GitHub workflow defining a set of jobs with a set of steps.
# ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions
#
name: Build

on:
pull_request:
paths-ignore:
- "docs/**"
- ".github/workflows/*.yaml"
- "!.github/workflows/build.yaml"
push:
paths-ignore:
- "docs/**"
- ".github/workflows/*.yaml"
- "!.github/workflows/build.yaml"
branches-ignore:
- "dependabot/**"
- "pre-commit-ci-update-config"
tags: ["**"]
workflow_dispatch:

jobs:
container:
runs-on: ubuntu-22.04
timeout-minutes: 10

steps:
- uses: actions/checkout@v4

- name: Build image
run: |
docker build -t jupyter-remote-desktop-proxy .
- name: Smoke test image
run: |
docker run -d -p 8888:8888 jupyter-remote-desktop-proxy
sleep 10
curl 'http://localhost:8888/desktop/?token=secret' | grep 'Modified from novnc_lite.html example in noVNC'
# TODO: Check VNC desktop works, e.g. by comparing Playwright screenshots
# https://playwright.dev/docs/test-snapshots
11 changes: 5 additions & 6 deletions Dockerfile
Expand Up @@ -20,10 +20,9 @@ RUN apt-get -y -q update \

USER $NB_USER

RUN mamba install --yes websockify
COPY --chown=$NB_UID:$NB_GID jupyter_remote_desktop_proxy /opt/install/jupyter_remote_desktop_proxy
COPY --chown=$NB_UID:$NB_GID environment.yml setup.py MANIFEST.in README.md LICENSE /opt/install/

COPY --chown=$NB_USER:$NB_USER jupyter_remote_desktop_proxy /opt/install/jupyter_remote_desktop_proxy
COPY --chown=$NB_USER:$NB_USER setup.py MANIFEST.in README.md LICENSE /opt/install/

RUN cd /opt/install \
&& pip install -e .
RUN cd /opt/install && \
. /opt/conda/bin/activate && \
mamba env update --quiet --file environment.yml

0 comments on commit 6a7204b

Please sign in to comment.